Implement stats calculations for new calculated_stats_ container
#468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alexdewar
requested changes
Jul 15, 2024
src/HealthGPS/analysis_module.h
Outdated
Comment on lines
48
to
49
| std::vector<std::string> channels_; | ||
| std::unordered_map<std::string, int> channel_index_; |
There was a problem hiding this comment.
I might not be completely understanding what these data structures do... But am I right in thinking channel_index_ contains indexes into channels_? If so, could you just make channels_ a std::map<std::string, std::string> (I'm guessing it needs to be ordered...) and drop channels_index_?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds much of the functionality to calculate the stats specified in
channels_. A lot of the logic for this is copied from the existing code, but modified to use thecalculated_stats_vector in place of the existingseriesobject. As a reminder, this is necessary because the calculated stats are being stored in a flat vector (calculated_stats_) which represents a multidimensional array of factors that the user wants to group by, as opposed to theseriesobject. A result of this is the introduction of thecalculate_indexmethod, and theget_channel_indexmethod - both necessary to find the correct index of the factor bin, and "channel" stat in thecalculated_stats_vector, respectively.